[tor-dev] Typo in relay metrics (circs_creared)

Mailing Lists tor-dev
1

Hi

I think, there’s a typo in the file “src/feature/relay/relay_metrics.c”. Shouldn’t the word “circs_creared” in the line

metrics_format_label(“action”, “circs_creared”));

be read as “circs_cleared”?

Andreas

PS:
Sorry, at the moment I’ve no clue what would be the correct way to send patches…

2 Likes
2

Hi,

Thanks for reporting this issue. It has already been reported and
fixed recently:

Sorry, at the moment I've no clue what would be the correct way to send patches...

The correct way to send a patch is to open a merge request against
The Tor Project / Core / Tor · GitLab .
To do so you need an account, which you can get by asking on
https://gitlab.onionize.space/.

Regards,
trinity-1686a

···

On Mon, 9 Jan 2023 at 11:12, Andreas Bollhalder <bolle@geodb.org> wrote:

Hi

I think, there's a typo in the file "src/feature/relay/relay_metrics.c". Shouldn't the word "circs_creared" in the line

metrics_format_label("action", "circs_creared"));

be read as "circs_cleared"?

Andreas

PS:
Sorry, at the moment I've no clue what would be the correct way to send patches... _______________________________________________
tor-dev mailing list
tor-dev@lists.torproject.org
tor-dev Info Page

_______________________________________________
tor-dev mailing list
tor-dev@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev

2 Likes
3

Hi Trinity (-1686a)

Thanks a lot for your reply. Nice to see that is was reported already. I’ve did some web searches, but nothing came up. For the next time, I’ll request an account for the GIT repo.

Andreas

···

On Monday, January 09, 2023 11:40 CET, trinity pointard trinity.pointard@gmail.com wrote:

Hi,

Thanks for reporting this issue. It has already been reported and
fixed recently:
metrics: Fix typo in a label (!665) · Merge requests · The Tor Project / Core / Tor · GitLab

Sorry, at the moment I’ve no clue what would be the correct way to send patches…

The correct way to send a patch is to open a merge request against
The Tor Project / Core / Tor · GitLab .
To do so you need an account, which you can get by asking on
https://gitlab.onionize.space/.

Regards,
trinity-1686a

On Mon, 9 Jan 2023 at 11:12, Andreas Bollhalder bolle@geodb.org wrote:

Hi

I think, there’s a typo in the file “src/feature/relay/relay_metrics.c”. Shouldn’t the word “circs_creared” in the line

metrics_format_label(“action”, “circs_creared”));

be read as “circs_cleared”?

Andreas

PS:
Sorry, at the moment I’ve no clue what would be the correct way to send patches… _______________________________________________
tor-dev mailing list
tor-dev@lists.torproject.org
tor-dev Info Page

tor-dev mailing list
tor-dev@lists.torproject.org
tor-dev Info Page